Skip to content

refactor: BI-0 Remove parent method copy-past #723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

refactor: BI-0 Remove parent method copy-past #723

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
436aae5
Remove parent method copypast
khamitovdr Nov 20, 2024
0339272
Remove unused import
khamitovdr Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 0 additions & 16 deletions ...nector_postgresql/dl_connector_postgresql/core/postgresql_base/async_adapters_postgres.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
Type,
TypeVar,
)
from urllib.parse import quote_plus
import uuid

import asyncpg
Expand Down Expand Up @@ -465,18 +464,3 @@ def _get_dsn_query_params(self) -> dict:
return {
"sslmode": "require" if self._target_dto.ssl_enable else "prefer",
}

def _get_dsn_params(
self,
safe_db_symbols: tuple[str, ...] = (),
db_name: Optional[str] = None,
standard_auth: Optional[bool] = True,
) -> dict:
return dict(
dialect=self._dialect_name,
user=quote_plus(self._target_dto.username) if standard_auth else None,
passwd=quote_plus(self._target_dto.password) if standard_auth else None,
host=quote_plus(self._target_dto.host),
port=quote_plus(str(self._target_dto.port)),
db_name=db_name or quote_plus(self._target_dto.db_name or "", safe="".join(safe_db_symbols)),
)
Loading