Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI GitHub Actions for United Storage #18

Merged
merged 3 commits into from
Oct 25, 2023
Merged

Conversation

goshander
Copy link
Contributor

No description provided.

@goshander goshander requested a review from jhoncool October 25, 2023 09:04
try {
currentEnv = readFileSync(path.join(appPath, '.env')).toString();
} catch (__) {
openSync(path.join(appPath, '.env'), 'w');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to open file .env?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copied from datalens-ui repo, i gues for creating empty file

Copy link
Collaborator

@jhoncool jhoncool Oct 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's strange, because below writeFileSync have called with default flag w

@goshander goshander merged commit 471c37b into main Oct 25, 2023
3 checks passed
@goshander goshander deleted the ci-github-actions-us branch October 25, 2023 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants