Initialize US with data for E2E tests #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vrozaev
reviewed
Oct 27, 2023
scripts/preflight.sh
Outdated
| @@ -25,5 +25,12 @@ if [ "$USE_DEMO_DATA" = "1" ]; then | |||
| echo "Finish setting up demo data" | |||
| fi | |||
|
|
|||
| if [ "$USE_E2E_MOCK_DATA" = "1" ]; then | |||
| echo "Start setting up e2e data" | |||
| sh /opt/e2e-data/init.sh | |||
There was a problem hiding this comment.
Could we add more context here via filename?
The name init-postgres-connection.sh might be better than just init.sh.
vrozaev
reviewed
Oct 27, 2023
scripts/preflight.sh
Outdated
| if [ "$USE_E2E_MOCK_DATA" = "1" ]; then | ||
| echo "Start setting up e2e data" | ||
| sh /opt/e2e-data/init.sh | ||
| node /opt/app/dist/server/db/scripts/e2e/init.js |
There was a problem hiding this comment.
Could we add more context here via filename?
The name init-united-storage-data.js might be better than just init.js.
vrozaev
reviewed
Oct 27, 2023
src/db/scripts/e2e/init.ts
Outdated
| console.error(err); | ||
| process.exit(1); | ||
| } | ||
| })(); |
There was a problem hiding this comment.
To discuss: do we really need a separate .ts file to setup united-storage data?
Looks like we can add a few lines to /opt/e2e-data/init.sh.
@imsitnikov what do you think?
There was a problem hiding this comment.
It seems like less relevant now as I removed this shell script.
There was a problem hiding this comment.
The current solution looks good. I don't have any questions.
vrozaev
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR
Related PR in UI datalens-tech/datalens-ui#129