Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add entry create/update availability check #224

Merged
merged 2 commits into from
Dec 24, 2024

Conversation

stepanenkoxx
Copy link
Contributor

No description provided.

Comment on lines +159 to +160
checkEntryPromise,
Lock.checkLock({entryId, lockToken}, ctx),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as I see checkEntry and checkLock are independent, so i guess we could run them in parallel

@stepanenkoxx stepanenkoxx marked this pull request as ready for review December 24, 2024 10:34
const registry = ctx.get('registry');
const {checkCreateEntryAvailability} = registry.common.functions.get();

await checkCreateEntryAvailability({ctx, scope});
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scope + type?

@stepanenkoxx stepanenkoxx merged commit 4da19f2 into main Dec 24, 2024
5 checks passed
@stepanenkoxx stepanenkoxx deleted the CHARTS-10825-check-entry-billing branch December 24, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants