-
Notifications
You must be signed in to change notification settings - Fork 12
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #357 from datamade/update-node-script
Update Node install script in Cookiecutter Dockerfiles
- Loading branch information
Showing
4 changed files
with
15 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,9 +9,13 @@ FROM python:3.11 | |
# Give ourselves some credit | ||
LABEL maintainer "DataMade <[email protected]>" | ||
|
||
# Add the NodeSource PPA | ||
# Add the NodeSource PPA and install Node.js | ||
# (see: https://github.com/nodesource/distributions/blob/master/README.md) | ||
RUN curl -sL https://deb.nodesource.com/setup_18.x | bash - | ||
RUN apt-get update \ | ||
&& apt-get install sudo \ | ||
&& curl -fsSL https://deb.nodesource.com/setup_{{ cookiecutter.node_version }}.x | sudo -E bash - \ | ||
&& sudo apt-get install -y nodejs | ||
|
||
|
||
# Install any additional OS-level packages you need via apt-get. RUN statements | ||
# add additional layers to your image, increasing its final size. Keep your | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,6 @@ | ||
{ | ||
"app_name": "new-project", | ||
"module_name": "project", | ||
"app_verbose_name": "Site Name" | ||
"app_verbose_name": "Site Name", | ||
"node_version": 21 | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,14 +4,17 @@ | |
# version number in the pilot. YMMV. See this post for a discussion of | ||
# some options and their pros and cons: | ||
# https://pythonspeed.com/articles/base-image-python-docker-images/ | ||
FROM python:3.9 | ||
FROM python:3.11 | ||
|
||
# Give ourselves some credit | ||
LABEL maintainer "DataMade <[email protected]>" | ||
|
||
# Add the NodeSource PPA | ||
# Add the NodeSource PPA and install Node.js | ||
# (see: https://github.com/nodesource/distributions/blob/master/README.md) | ||
RUN curl -sL https://deb.nodesource.com/setup_12.x | bash - | ||
RUN apt-get update \ | ||
&& apt-get install sudo \ | ||
&& curl -fsSL https://deb.nodesource.com/setup_{{ cookiecutter.node_version }}.x | sudo -E bash - \ | ||
&& sudo apt-get install -y nodejs | ||
|
||
# Install any additional OS-level packages you need via apt-get. RUN statements | ||
# add additional layers to your image, increasing its final size. Keep your | ||
|