Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rename blacklist to blocklist for email domain validation #469

Merged
merged 1 commit into from
Mar 21, 2025

Conversation

mirkan1
Copy link
Member

@mirkan1 mirkan1 commented Mar 21, 2025

What type of PR is this?

I saw this error on vs-studio, it was weird that it didnt throw an error..
After testing manualy I figured that both blacklist and blocklist exists in the third party repo but it is not visible in the configs so was cousing troubles for vs code, this change fixed the issue

  • Refactor
  • Bug Fix

Description

No name 'blacklist' in module 'disposable_email_domains'Pylint[E0611:no-name-in-module]

How is this tested?

  • Manually

Related Tickets & Documents

https://pylint.readthedocs.io/en/latest/user_guide/messages/error/no-name-in-module.html

Copy link

Code Coverage

Package Line Rate Health
. 76%
authentication 66%
cli 68%
destinations 47%
gcloud 100%
handlers 76%
metrics 94%
models 89%
plywood 42%
plywood.objects 52%
plywood.parsers 85%
query_runner 39%
serializers 76%
services 96%
settings 96%
tasks 64%
tasks.queries 82%
templates._includes 100%
utils 69%
Summary 62% (8595 / 13968)

Minimum allowed line rate is 60%

@jaroslawherod jaroslawherod merged commit 8434084 into develop Mar 21, 2025
2 checks passed
@mirkan1 mirkan1 deleted the blacklist branch March 23, 2025 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants