Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The interface of Section.add_cells is non-intuintive #172

Open
mbelak-dtml opened this issue Oct 10, 2023 · 1 comment
Open

The interface of Section.add_cells is non-intuintive #172

mbelak-dtml opened this issue Oct 10, 2023 · 1 comment
Labels
technical debt Technical debt

Comments

@mbelak-dtml
Copy link
Collaborator

The method add_cells gets a list, which it is expected to modify.
It would be more intuitive if the method instead returned the cells it needs to add instead of modifying a parameter.
@mbelak-dtml mbelak-dtml added the technical debt Technical debt label Oct 10, 2023
@mbelak-dtml mbelak-dtml mentioned this issue Oct 10, 2023
Merged
@mbelak-dtml
Copy link
Collaborator Author

See #159 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
technical debt Technical debt
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mbelak-dtml