Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: test exported code executes #159

Merged
merged 6 commits into from
Oct 11, 2023
Merged

test: test exported code executes #159

merged 6 commits into from
Oct 11, 2023

Conversation

mbelak-dtml
Copy link
Collaborator

Resolves #8

@mbelak-dtml mbelak-dtml self-assigned this Oct 2, 2023
@mbelak-dtml mbelak-dtml marked this pull request as ready for review October 9, 2023 13:54
lukany
lukany requested changes Oct 9, 2023
View reviewed changes
tests/execution_utils.py Show resolved Hide resolved
tests/test_bivariate_analysis.py Outdated Show resolved Hide resolved
@mbelak-dtml
chore: add codeowners (#166)
6072ea2
@mbelak-dtml
fix: fix default number of histogram bins being extremely high (#167)
b0a1e2e 
The high number of bins caused extreme loss of performance for some
specific data.
For example, for the column `mass (g)` of the
`edvart.example_datasets.dataset_meteorite_landings()`, the number of
inferred bins is over 5M, even though the dataset contains under 50k
rows.
@mbelak-dtml mbelak-dtml mentioned this pull request Oct 10, 2023
Open
lukany
lukany requested changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@lukany lukany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one more nitpick, sorry, I feel like we invest more time to this PR than needed 😅

edvart/report_sections/univariate_analysis.py Outdated Show resolved Hide resolved
@lukany lukany added this pull request to the merge queue Oct 11, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Oct 11, 2023
@mbelak-dtml mbelak-dtml added this pull request to the merge queue Oct 11, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Oct 11, 2023
@mbelak-dtml mbelak-dtml added this pull request to the merge queue Oct 11, 2023
Merged via the queue into main with commit c22b69e Oct 11, 2023
6 checks passed
@mbelak-dtml mbelak-dtml deleted the test/test-code-executes branch October 11, 2023 09:23
@mbelak-dtml mbelak-dtml mentioned this pull request Oct 12, 2023
Merged
github-merge-queue bot pushed a commit that referenced this pull request Oct 13, 2023
@mbelak-dtml
ci: execute tests in parallel (#185)
6b4ac26 
With #159 and #162, we have added more and longer-running tests, which
results in the test suite taking over 10 minutes to complete. Since the
tests are independent of each other, they can be run in parallel.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukany lukany lukany approved these changes

Assignees

@mbelak-dtml mbelak-dtml

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test that generated code executes
2 participants
@mbelak-dtml @lukany