Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change required ruby version after upgrading rubocop-graphql #278

Merged

Conversation

an-korn
Copy link
Member

@an-korn an-korn commented Dec 8, 2023

Currently checks are failed on current version. It's appeared after upgrading rubocop-graphql in cbc6697 to rubocop-graphql >= 1.2.0 which depends on Ruby >= 3.0.

Before you submit a pull request, please make sure you have to follow:

  • read and know items from the Contributing Guide
  • add a description of the problem you're trying to solve (short summary from related issue)
  • verified that cops are ordered by alphabet
  • add a note to the style guide docs (if it needs)
  • add a note to the changelog file
  • the commit message contains the number of the related issue (if it presents)
    and word Fix if this PR closes related issue
  • squash all commits before submitting to review

@an-korn an-korn force-pushed the change-required-ruby-version-after-upgrading-rubocop-graphql branch 2 times, most recently from c695102 to c3bdb0e Compare August 26, 2024 16:45
@an-korn an-korn force-pushed the change-required-ruby-version-after-upgrading-rubocop-graphql branch from c3bdb0e to 2b5d17a Compare August 26, 2024 16:55
@an-korn an-korn merged commit 38c7047 into master Aug 26, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants