Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix summaries in MultiGtfsInstance #233

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Fix summaries in MultiGtfsInstance #233

merged 1 commit into from
Jan 17, 2024

Conversation

cbrowning04
Copy link
Contributor

@cbrowning04 cbrowning04 commented Jan 15, 2024

Description

This PR fixes an issue where summarise_routes(to_days=False) and summarise_trips(to_days=False) returned identical results. This has been fixed by dropping duplicates.

Fixes #228

Motivation and Context

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Test configuration details:

  • OS: Windows 10
  • Python version: 3.9.13
  • Java version: n/a
  • Python management system: Conda

Advice for reviewer

Checklist:

  • My code follows the intended structure of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional comments

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (42e6dd1) 97.62% compared to head (0bb4b70) 97.62%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #233   +/-   ##
=======================================
  Coverage   97.62%   97.62%           
=======================================
  Files          20       20           
  Lines        1770     1770           
=======================================
  Hits         1728     1728           
  Misses         42       42           
Flag Coverage Δ
unittests 97.62% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@r-leyshon r-leyshon self-assigned this Jan 17, 2024
Copy link
Contributor

@r-leyshon r-leyshon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have checked numbers of routes against the Newport and Chester feed routes and confirmed that the numbers are as expected. Here with mult gtfs:
image

Here with single GTFS:
image

image
Trip count is different:

image

@r-leyshon r-leyshon merged commit aa98494 into dev Jan 17, 2024
9 checks passed
@r-leyshon r-leyshon deleted the mgtfs_summaries_fix branch January 17, 2024 08:57
github-actions bot pushed a commit that referenced this pull request Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

multigtfs summarise routes & trips are identical
3 participants