Fix build time performance improvements #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce a new `RoughPy_PrecompiledHeaders` target to reduce build time, especially for cereal header parsing. Adjust CMakeLists for relevant modules to link against the new precompiled headers target.
Upgraded msbuild setup action to version 2 in the tests.yml file to ensure compatibility with the latest features and improvements. This change is scoped to the Windows runner environment in the GitHub CI workflow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build performance of RougPy is somewhat lacking, especially on Windows where we have to use MSVC (by far the slowest compiler of the three). To combat this, we define a new PrecompiledHeaders target that we can link to that contains all the private headers that we need all over the place in RoughPy that take a lot of time to process. This mainly consists of cereal, which ultimately we want to remove because it is so expensive to instantiate, and a pain to integrate across API boundaries. (Removing this is somewhat down the line.)