Fixed the degree bits in the libalgebra lite index_key type #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The index_key is used for basis keys for libalgebra_lite tensors and Lie algebras. The default number of bits was set to 4, meaning a maximum of degree 15 for basis keys. This is probably the source of numerous errors in RoughPy when using degree >= 16. This change fixes the number of bits to 8, giving a maximum of degree 255, which should be completely sufficient until we can finally get rid of libalgebra_lite and replacing the badness within
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The index_key is used for basis keys for libalgebra_lite tensors and Lie algebras. The default number of bits was set to 4, meaning a maximum of degree 15 for basis keys. This is probably the source of numerous errors in RoughPy when using degree >= 16. This change fixes the number of bits to 8, giving a maximum of degree 255, which should be completely sufficient until we can finally get rid of libalgebra_lite and replacing the badness within