Fix infinite loop if support not specified #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces three new tests to validate the equivariance property of signatures for tree-like paths. Ensures consistency between original paths and their pruned representations using `esig_stream2sig`. These additions strengthen coverage for stream behavior in edge cases.
Replaced right_unbounded interval creation with direct initialization of `effective_support`. Added fallback to `effective_support` when `md.support` is not provided, ensuring proper restriction behavior.
inakleinbottle
deleted the
fix-infinite-loop-if-support-not-specified
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The esig interface exposed a bug in which not specifying the support would cause an infinite loop as the dyadic intervals over the unbounded interval [0, +inf) were enumerated in the case where no increments were provided to stream constructor. This is caused by the construct setting the unbounded interval as the default value, which is usually overwritten by either the additional arguments or is inferred from the timestamps during the construction process. Of course, both fail is the support is not provided and no data is provided. This is now fixed by setting the effective support to [0, 1).