Fix bug signature domain #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test validates the computed linear signature against expected values, covering levels 0 to 3. It includes an explanation for the adjusted divisor in level 3 due to symmetry considerations, ensuring numerical accuracy.
Updated the `signature` method call to include a `resolution` parameter in the test case for `LieIncrementStream`. This change ensures consistency with the expected method signature and enhances test clarity.
Ensure the resolution is updated if it’s lower than the refined query's second value. This prevents inconsistencies and ensures proper handling in `log_signature_impl`.
The conditional update of the resolution variable was redundant and has been removed. This simplifies the code and ensures that `log_signature_impl` is called with the correct parameters without modifying resolution prematurely.
The 'resolution' parameter in the 'signature' method call was redundant and has been removed for clarity. This ensures the test reflects the current API usage and avoids potential confusion.
|
The fix in #188 actually caused a new bug in the wider ecosystem exposed in the previous run of the CI here. The fix has been removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The internals of Lie increment path have changed somewhat leading to a problem whereby requesting a signature over the unit interval with resolution 0, does not provide the correct answer. The problem is that internally the query interval is trimmed to without an adjusted resolution. This PR fixes this issue.