Fix install path cmake #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The install script was updated to correct the relative path of the py.typed file. This ensures the file is properly included in the installation process, aligning with project requirements.
Included Libalgebra_lite in the list of linked libraries in CMakeLists.txt to support necessary algebraic computations. This ensures proper functionality and integration with the project's requirements.
The Python source files are now installed in the correct `roughpy` directory instead of the project root. This ensures proper package structure and resolves issues with module imports.
Moved Python module installation logic from `roughpy/CMakeLists.txt` to the main `CMakeLists.txt` for better organization and clarity. This ensures all installation steps are consolidated and improves maintainability of the build configuration.
Updated the path for the py.typed file to include the correct directory, ensuring proper installation. This resolves potential issues with type hinting in package deployments.
Adjusted the install command to ensure `py.typed` is included correctly by matching patterns. This change ensures proper packaging of Python-related files while excluding unnecessary source directories.
Upgraded Windows runner to windows-2022 and added missing setup steps for Windows builds, including msbuild, ninja, and pkgconfig. Standardized CMake generator to "Ninja" across workflows for consistency. Removed redundant "use ninja" step in tests.yml for cleanup.
Cleaned up unnecessary blank lines in the GitHub Actions workflow file. This improves readability and maintains consistency in the file structure.
Boost-stacktrace was unnecessary and has been removed to streamline the dependency list. This change reduces potential overhead and improves maintainability.
Simplified the script by removing OS-specific dependency installations and unused Mono setup. Updated `vcpkg` cloning to target the `tools/vcpkg` directory and streamlined the bootstrap process. Unused and commented-out token-based binary caching logic was also removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a couple of CMake errors that prevented the install step working in the wheel building.
Also fixed a couple of small issues in the actions.