Fix pool allocator #190
Merged
Fix pool allocator #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit includes the boost-pool library with version 1.86.0 as a new dependency. It ensures required functionality is available for memory pooling. No other changes were made to the dependency list.
The Boost.Pool library has been included in the list of dependencies in CMakeLists.txt. This change ensures that the project can leverage memory pooling functionality provided by Boost.
Replaced standard polymorphic memory resource with Boost's `pool` for small object allocation. This improves alignment handling and simplifies the custom allocator logic while maintaining proper deallocation behavior. Removed obsolete commented-out code for clarity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Older versions of libc++, such as those found on MacOs <14, don't implement
std::pmr::memory_resource, but for some reason still compiles and links. This leads to a rather frustrating missing symbol error at load-time, causing the program to fail unexpectedly. For this reason, I've swapped out thestd::pmr::synchronized_pool_allocatorfor aboost::poolthat also provides a pool-style allocator that we can use for small objects. I don't know if this functions in precisely the same way was the std version, but at least it is platform independent and faster than "malloc"ing everything.