Fix build wheel action #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change ensures necessary tools (curl, zip, unzip, tar) are installed on Linux systems during the CI setup. It uses the OSTYPE variable to detect the operating system and installs the packages only when running on Linux.
This field was likely a leftover and is no longer needed in the configuration. Its removal simplifies the setup and avoids potential confusion or misconfigurations.
The conditional definition for BOOST_STACKTRACE_GNU_SOURCE_NOT_REQUIRED was removed from the build script. This cleanup ensures the codebase is more concise and avoids unnecessary platform-specific configurations.
Removed the `-DROUGHPY_BUILD_PYMODULE_INPLACE=ON` flag from the CMake command in `tests.yml`. This change streamlines the configuration process while maintaining required build and test settings.
The `CMAKE_GENERATOR` variable was defined but not used in the workflow. This cleanup reduces unnecessary configuration and improves readability of the build script.
Commented out the step to install pkgconfig on Windows using Chocolatey. This change may simplify workflows if pkgconfig is not required or managed differently. Revisit if future dependencies demand it.
This update ensures proper configuration for building on Windows runners by setting up MSBuild and enabling the developer command prompt. These steps help streamline the build process and maintain cross-platform consistency.
Added SKBUILD_CMAKE_DEFINE to the Windows build configuration in pyproject.toml. This ensures compatibility with specific compiler settings during the build process.
Updated the 'environment' field in the Windows build configuration from a list to a table for improved clarity and consistency. This change aligns with standard TOML formatting guidelines.
Added `CMAKE_GENERATOR` as "Ninja" in the build workflow to optimize builds. Removed an unused `SKBUILD_CMAKE_DEFINE` environment variable from the Windows configuration in `pyproject.toml` for cleanup and consistency.
Added the `CMAKE_TOOLCHAIN_FILE` environment variable to the GitHub Actions `build_wheels.yml` workflow to ensure proper configuration using vcpkg. This update facilitates dependency management and improves build consistency across environments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The wheel action needed an update to make it use Ninja on Windows; MSBuild is painfully slow and Ninja makes this run much faster. Bringing over the settings from the test action made the build fail. It turned out that Visual studio brought it's own version of VCPKG that was being used preferentially because VCPKG_ROOT was not set in the wheels action. This caused the installation of dependencies to fail (out-of-date vcpkg or something more sinister). This is fixed by setting the toolchain explicitly, like in the tests action. For some reason, this makes the installation successful.