Skip to content

CNDB-13591: Go back to storing byte buffers in the cache#1678

Closed
blambov wants to merge 3 commits intomainfrom
CNDB-13591
Closed

CNDB-13591: Go back to storing byte buffers in the cache#1678
blambov wants to merge 3 commits intomainfrom
CNDB-13591

Conversation

@blambov
Copy link
Copy Markdown

@blambov blambov commented Apr 4, 2025

What is the issue

https://github.com/riptano/cndb/issues/9104 included conversion of ByteBuffers to addresses to decrease the space usage of the chunk cache. This seems to cause a lot of chunk cache corruption (see https://github.com/riptano/cndb/issues/13591).

What does this PR fix and why was it fixed

Switches back to storing the passed ByteBuffers.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 4, 2025

Checklist before you submit for review

  • Make sure there is a PR in the CNDB project updating the Converged Cassandra version
  • Use NoSpamLogger for log lines that may appear frequently in the logs
  • Verify test results on Butler
  • Test coverage for new/modified code is > 80%
  • Proper code formatting
  • Proper title for each commit staring with the project-issue number, like CNDB-1234
  • Each commit has a meaningful description
  • Each commit is not very long and contains related changes
  • Renames, moves and reformatting are in distinct commits
  • All new files should contain the DataStax copyright header instead of the Apache License one

Enrico Olivelli and others added 2 commits April 4, 2025 16:09
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 4, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
76.2% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@cassci-bot
Copy link
Copy Markdown

❌ Build ds-cassandra-pr-gate/PR-1678 rejected by Butler


2 new test failure(s) in 2 builds
See build details here


Found 2 new test failures

Test Explanation Branch history Upstream history
...titionsTest.testServiceTopPartitionsSingleTable regression 🔴🔵 🔵🔵🔵🔵🔵🔵🔵
o.a.c.u.b.BinLogTest.testTruncationReleasesLogS... regression 🔴🔵 🔵🔵🔵🔵🔵🔵🔵

Found 1 known test failures

@JeremiahDJordan
Copy link
Copy Markdown
Member

This has been merged in #1719

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants