CNDB-13591: Go back to storing byte buffers in the cache#1678
Closed
CNDB-13591: Go back to storing byte buffers in the cache#1678
Conversation
Checklist before you submit for review
|
…Exception: Negative position
|
❌ Build ds-cassandra-pr-gate/PR-1678 rejected by Butler2 new test failure(s) in 2 builds Found 2 new test failures
Found 1 known test failures |
Member
|
This has been merged in #1719 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


What is the issue
https://github.com/riptano/cndb/issues/9104 included conversion of
ByteBuffers to addresses to decrease the space usage of the chunk cache. This seems to cause a lot of chunk cache corruption (see https://github.com/riptano/cndb/issues/13591).What does this PR fix and why was it fixed
Switches back to storing the passed
ByteBuffers.