fix a couple of compiler warnings #145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgier
force-pushed
the
fix-compiler-warnings
branch
2 times, most recently
from
a2c9fe3 to
428190c
Compare
- [WARNING] kaap/operator/src/main/java/com/datastax/oss/kaap/crds/GlobalSpec.java:[42,1] Generating equals/hashCode implementation but without a call to superclass, even though this class does not extend java.lang.Object. If this is intentional, add '@EqualsAndHashCode(callSuper=false)' to your type.
pgier
force-pushed
the
fix-compiler-warnings
branch
from
428190c to
b0f05f7
Compare
nicoloboschi
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[WARNING] kaap/operator/src/main/java/com/datastax/oss/kaap/crds/GlobalSpec.java:[42,1] Generating equals/hashCode implementation but without a call to superclass, even though this class does not extend java.lang.Object. If this is intentional, add '@EqualsAndHashCode(callSuper=false)' to your type.
[WARNING] Annotation: javax.validation.constraints.NotNull on property: getName is deprecated. Please use: io.fabric8.generator.annotation.Required insteadIt seems that this one is intentional False negative warning combining spec's pojo and Java Bean Validation in CRD generator fabric8io/kubernetes-client#4577
And it will be fixed by upgrade quarkus-sdk 5.0.1->5.1.4 #146