This repository has been archived by the owner on Sep 13, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1
new single-page visualization editor #86
Draft
gka
wants to merge
53
commits into
feature/navbar
Choose a base branch
from
feature/edit-route
base: feature/navbar
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gka
force-pushed
the
feature/edit-route
branch
2 times, most recently
from
August 26, 2021 08:15
cdf8657
to
7863f61
Compare
gka
force-pushed
the
feature/edit-route
branch
6 times, most recently
from
September 2, 2021 09:58
1267e00
to
97c5835
Compare
* feat: show list of teams in submenu * feat: show active team in create menu * styles refactoring to reach TeamSelect and VisArchive * feat: user can switch active team via submenu * ui: fix styles in vis archive * show active team in hello world view * check if user.teams exists * show active team in hello world page * add "(private)" to no team * bump service-utils
* feat: signout via nav bar * limit navbar options for guests * feat: signup form * feat: new signup form design * refactoring * variable height * make new signin page a layout * title * fix * add password check * translations * more translations * slightly adapt old signin page layout * implement sign in * add auth strategy user * no box shadow * show login by default * rename index * refactore login and signup into separate views * signin: refactoring * reset password * nicer provider icons * .. * use mail icon * read list of signin providers from config * l10n: update translations * l10n: update translations * translations * prevent guest accesss * fix signup layout on mobile * more helpful error message on ssr eval failures * only show providers in two columns if there are more than 3
feat: new signup form design refactoring variable height make new signin page a layout title translations rename index signin: refactoring
show active team in hello world page experimental edit step step nav finish step nav automatically store chart changes respect & update last_edit_step visualize step mockup refactoring svelte2wrapper: allow specifying which component to render make createAPI method usable throughout frontend load amd sync chart data as well visualize tabs edit: sticky editor nav sticky sub-step nav tabs in visualize
fix vis archive fix after rebase
gka
force-pushed
the
feature/edit-route
branch
from
September 6, 2021 11:11
97c5835
to
a69140f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
/v2/edit/{chartId}/{step?}
route to the frontend, which renders thesrc/views/edit/App.svelte
view, which mostly takes care of the SPA routing.src/views/edit/nav/Header.svelte
,src/views/edit/nav/Step.svelte
)Upload.svelte
,Describe.svelte
,Visualize.svelte
, andPublish.svelte
src/views/edit/visualize
, and components for the other steps will be placed in similar pathssrc/views/edit/stores.js
which contains the code for thechart
anddata
stores, including the synchronization to our database (so far only client --> server)