Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Deutsche Medien-Manufaktur GmbH & Co. KG' (community contribution) #3029

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

datenanfragen-community-edits
Copy link
Collaborator

@datenanfragen-community-edits datenanfragen-community-edits commented Mar 1, 2025

This suggestion was submitted through the website.

Edit in: company JSON generator, data editor1

Footnotes

  1. Closed beta

@datenanfragen-community-edits datenanfragen-community-edits added the record Issue related to the JSON records label Mar 1, 2025
@datenanfragen-community-edits datenanfragen-community-edits force-pushed the suggest_deutsche-medien-manufaktur-gmbh-co-kg_1740836952587 branch from c1e9194 to f880379 Compare March 1, 2025 13:49
"runs": [
"Landlust"
],
"address": "Hülsebrockstraße 2-8\n48165 Münster",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <end-address-in-country> reported by reviewdog 🐶
Last line of address (48165 Münster) is not a country.

We've decided on specific variations for these countries:

  • United States of America
  • The Netherlands
  • Republic of Singapore
Suggested change
"address": "Hülsebrockstraße 2-8\n48165 Münster",
"address": "Hülsebrockstraße 2-8\n48165 Münster\nAustria",
Suggested change
"address": "Hülsebrockstraße 2-8\n48165 Münster",
"address": "Hülsebrockstraße 2-8\n48165 Münster\nÖsterreich",
Suggested change
"address": "Hülsebrockstraße 2-8\n48165 Münster",
"address": "Hülsebrockstraße 2-8\n48165 Münster\nGermany",
Suggested change
"address": "Hülsebrockstraße 2-8\n48165 Münster",
"address": "Hülsebrockstraße 2-8\n48165 Münster\nDeutschland",

"Landlust"
],
"address": "Hülsebrockstraße 2-8\n48165 Münster",
"phone": "025018013110",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <pass-schema> reported by reviewdog 🐶
Record did not pass schema validation: “The value at /phone is an invalid string.”

Raw error:

{
    "path": "$.phone",
    "pointer": "/phone",
    "message": "The value at /phone is an invalid string.",
    "data": "025018013110"
}

"phone": "025018013110",
"email": "[email protected]",
"sources": [
"Brief",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <pass-schema> reported by reviewdog 🐶
Record did not pass schema validation: “The value at /sources/0 must be a valid URI string but it was not.”

Raw error:

{
    "path": "$.sources[0]",
    "pointer": "/sources/0",
    "message": "The value at /sources/0 must be a valid URI string but it was not.",
    "data": "Brief"
}

Comment on lines +21 to +23
{
"type": "input"
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <pass-schema> reported by reviewdog 🐶
Record did not pass schema validation: “The value at /required-elements/0 is missing the required field 'desc'.”

Raw error:

{
    "path": "$.required-elements[0]",
    "pointer": "/required-elements/0",
    "message": "The value at /required-elements/0 is missing the required field 'desc'.",
    "data": {
        "type": "input"
    }
}

Comment on lines +20 to +24
"required-elements": [
{
"type": "input"
}
],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [companylint] <name-in-required-elements> reported by reviewdog 🐶
Record has required elements but no name element.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
record Issue related to the JSON records via-suggest-api
Development

Successfully merging this pull request may close these issues.

2 participants