found and fixed a bug in getDateRelative()
#953
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have modified `getDateRelative()` so that the basis for calculating the time difference is the date and not the time (86400s (24h)). This had the consequence that `getDateRelative()` a page that was created yesterday at 18:00 o'clock, today at 13:00 o'clock `today` output, which is definitely wrong. Now the date of the publication is checked and compared with today's date.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug in the function
getDateRelative()results in a page created at 18:00 being output at 13:00 on the following daytodayas relative date, which is wrong.I have modified
getDateRelative()so that the basis for calculating the time difference is the date and not the time (86400s (24h)) so now the date of the publication is checked against today's date and outputs the correct relative date.