Skip to content

Commit

Permalink
use faster to_ascii_lowercase when possible
Browse files Browse the repository at this point in the history
  • Loading branch information
jqnatividad committed Feb 15, 2024
1 parent 2188b02 commit 79045ff
Show file tree
Hide file tree
Showing 8 changed files with 14 additions and 13 deletions.
2 changes: 1 addition & 1 deletion src/cmd/apply.rs
Original file line number Diff line number Diff line change
Expand Up @@ -595,7 +595,7 @@ pub fn run(argv: &[&str]) -> CliResult<()> {
// we set it to empty string
let flag_replacement = if apply_cmd == ApplySubCmd::Operations
&& ops_vec.contains(&Operations::Regex_Replace)
&& args.flag_replacement.to_lowercase() == NULL_VALUE
&& args.flag_replacement.to_ascii_lowercase() == NULL_VALUE
{
String::new()
} else {
Expand Down
2 changes: 1 addition & 1 deletion src/cmd/applydp.rs
Original file line number Diff line number Diff line change
Expand Up @@ -430,7 +430,7 @@ pub fn run(argv: &[&str]) -> CliResult<()> {
// we set it to empty string
let flag_replacement = if applydp_cmd == ApplydpSubCmd::Operations
&& ops_vec.contains(&Operations::Regex_Replace)
&& args.flag_replacement.to_lowercase() == NULL_VALUE
&& args.flag_replacement.to_ascii_lowercase() == NULL_VALUE
{
String::new()
} else {
Expand Down
2 changes: 1 addition & 1 deletion src/cmd/excel.rs
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ pub fn run(argv: &[&str]) -> CliResult<()> {
.extension()
.and_then(std::ffi::OsStr::to_str)
.unwrap_or_default()
.to_lowercase();
.to_ascii_lowercase();
let ods_flag = match format.as_str() {
"xls" | "xlsx" | "xlsm" | "xlsb" => false,
"ods" => true,
Expand Down
4 changes: 2 additions & 2 deletions src/cmd/luau.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1413,7 +1413,7 @@ fn create_index(arg_input: &Option<String>) -> Result<bool, CliError> {
return Ok(false);
};

if input.to_lowercase().ends_with(".sz") {
if input.to_ascii_lowercase().ends_with(".sz") {
log::warn!("qsv_autoindex() does not work with snappy files.");
return Ok(false);
}
Expand Down Expand Up @@ -1481,7 +1481,7 @@ fn setup_helpers(
let val = luau.from_value::<serde_json::Value>(val)?;
let val_str = &serde_json::to_string_pretty(&val).unwrap_or_default();
if idx == 0 {
log_level = val_str.trim_matches('"').to_lowercase();
log_level = val_str.trim_matches('"').to_ascii_lowercase();
} else {
log_msg.push_str(val_str.trim_matches('"'));
if idx == u8::MAX {
Expand Down
4 changes: 2 additions & 2 deletions src/cmd/sqlp.rs
Original file line number Diff line number Diff line change
Expand Up @@ -351,7 +351,7 @@ impl FromStr for OutputMode {
type Err = String;

fn from_str(s: &str) -> Result<Self, Self::Err> {
match s.to_lowercase().as_str() {
match s.to_ascii_lowercase().as_str() {
"csv" => Ok(OutputMode::Csv),
"json" => Ok(OutputMode::Json),
"parquet" => Ok(OutputMode::Parquet),
Expand All @@ -376,7 +376,7 @@ impl FromStr for PqtCompression {
type Err = String;

fn from_str(s: &str) -> Result<Self, Self::Err> {
match s.to_lowercase().as_str() {
match s.to_ascii_lowercase().as_str() {
"uncompressed" => Ok(PqtCompression::Uncompressed),
"gzip" => Ok(PqtCompression::Gzip),
"snappy" => Ok(PqtCompression::Snappy),
Expand Down
4 changes: 2 additions & 2 deletions src/cmd/stats.rs
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,7 @@ pub fn run(argv: &[&str]) -> CliResult<()> {
false
} else {
let p = args.flag_output.clone().unwrap();
p.to_lowercase().ends_with(".sz")
p.to_ascii_lowercase().ends_with(".sz")
},
canonical_input_path: String::new(),
canonical_stats_path: String::new(),
Expand Down Expand Up @@ -888,7 +888,7 @@ fn init_date_inference(
let dmy_preferred = prefer_dmy || util::get_envvar_flag("QSV_PREFER_DMY");
DMY_PREFERENCE.store(dmy_preferred, Ordering::Relaxed);

let whitelist_lower = flag_whitelist.to_lowercase();
let whitelist_lower = flag_whitelist.to_ascii_lowercase();
log::info!("inferring dates with date-whitelist: {whitelist_lower}");

let infer_date_flags = if whitelist_lower == "all" {
Expand Down
2 changes: 1 addition & 1 deletion src/config.rs
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ impl Config {
.unwrap_or_default()
.to_str()
.unwrap()
.to_lowercase();
.to_ascii_lowercase();
let mut snappy = false;
let delim = if file_extension == "tsv" || file_extension == "tab" {
b'\t'
Expand Down
7 changes: 4 additions & 3 deletions src/util.rs
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,7 @@ pub fn show_env_vars() {
#[cfg(feature = "mimalloc")]
if env_var.starts_with("QSV_")
|| env_var.starts_with("MIMALLOC_")
|| OTHER_ENV_VARS.contains(&env_var.to_lowercase().as_str())
|| OTHER_ENV_VARS.contains(&env_var.to_ascii_lowercase().as_str())
{
env_var_set = true;
woutinfo!("{env_var}: {v:?}");
Expand All @@ -269,13 +269,14 @@ pub fn show_env_vars() {
if env_var.starts_with("QSV_")
|| env_var.starts_with("JEMALLOC_")
|| env_var.starts_with("MALLOC_CONF")
|| OTHER_ENV_VARS.contains(&env_var.to_lowercase().as_str())
|| OTHER_ENV_VARS.contains(&env_var.to_ascii_lowercase().as_str())
{
env_var_set = true;
woutinfo!("{env_var}: {v:?}");
}
#[cfg(not(any(feature = "mimalloc", feature = "jemallocator")))]
if env_var.starts_with("QSV_") || OTHER_ENV_VARS.contains(&env_var.to_lowercase().as_str())
if env_var.starts_with("QSV_")
|| OTHER_ENV_VARS.contains(&env_var.to_ascii_lowercase().as_str())
{
env_var_set = true;
woutinfo!("{env_var}: {v:?}");
Expand Down

0 comments on commit 79045ff

Please sign in to comment.