Merge pull request #1274 from jqnatividad/excel-formula-empty-string-…

…value `excel`: we can now open workbooks with formulas set to an empty string value
dathere · Sep 2, 2023 · e391582 · e391582
2 parents 7b7b887 + 0720a24
commit e391582
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 2 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/Cargo.toml b/Cargo.toml
@@ -226,7 +226,7 @@ serial_test = { version = "2.0", features = ["file_locks"] }
 [patch.crates-io]
 geosuggest-core  = { git = "https://github.com/estin/geosuggest", rev = "5c6b08b" }
 geosuggest-utils = { git = "https://github.com/estin/geosuggest", rev = "5c6b08b" }
-calamine = { git = "https://github.com/tafia/calamine", rev = "a54bd9c" }
+calamine = { git = "https://github.com/jqnatividad/calamine", branch = "formula_empty_string_value" }
 
 [features]
 default = ["mimalloc"]

diff --git a/resources/test/formula_empty_string_value.xls b/resources/test/formula_empty_string_value.xls
diff --git a/tests/test_excel.rs b/tests/test_excel.rs
@@ -1419,3 +1419,15 @@ fn excel_range_empty_sheet() {
         .is_some());
     wrk.assert_err(&mut cmd);
 }
+
+#[test]
+fn excel_formula_empty_string_value() {
+    let wrk = Workdir::new("formula_empty_string_value");
+
+    let xls_file = wrk.load_test_file("formula_empty_string_value.xls");
+
+    let mut cmd = wrk.command("excel");
+    cmd.arg(xls_file);
+
+    wrk.assert_success(&mut cmd);
+}