excel: moar metadata! moar examples!
#1271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jqnatividad
commented
Sep 2, 2023
jqnatividad
commented
- now retrieves SheetType metadata (Worksheet, DialogSheet, MacroSheet, ChartSheet, VBA)
- now retrieves Sheet Visibility metadata (Visible, Hidden, VeryHidden)
- returns an error when trying to export a non-Worksheet SheetType sheet
- added examples beyond just referring to test suite
- now retrieves SheetType (Worksheet, DialogSheet, MacroSheet, ChartSheet, VBA) - now retrieves Visibility: (Visible, Hidden, VeryHidden) - returns an error when trying to export a non Worksheet SheetType sheet - added examples beyond just referring to test suite
false positive lint warning as we actually need to clone for iter().enumerate() later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.