diff: add option/flag for headers in output
#1395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 31, 2023 16:23
Provide a single method for renaming into `all_generic` pattern and expose it publicly for reuse.
added 2 commits
October 31, 2023 18:23
This implements a new option for `diff`: It is now possible to decide,
whether the CSV headers in the compared CSVs should be in the diff
output. If neither CSVs have headers and this option is _not_ active
(which means the output _should_ have headers), the `all_generic`
strategy from `rename` is used (`_col_1`, `_col_2`, etc.).
Example 1 (no diff, no headers in result):
csv_left.csv col1,col2,col3
1,foo,bar
csv_right.csv 1,foo,bar
qsv diff --no-headers-result --no-headers-right csv_left.csv csv_right.csv
Output: <nothing will be printed here, because there are no differences
and we don't want to print headers in the result>
------------------------------------------------------------------------
Example 2 (has diff, no headers in result):
csv_left.csv col1,col2,col3
1,foo,bar
csv_right.csv 1,foo,baz
qsv diff --no-headers-result --no-headers-right csv_left.csv csv_right.csv
Output: -,1,foo,bar
+,1,foo,baz
------------------------------------------------------------------------
Example 3 (has diff, add generic headers):
csv_left.csv 1,foo,bar
csv_right.csv 1,foo,baz
qsv diff --no-headers-left --no-headers-right csv_left.csv csv_right.csv
Output: diffresult,_col_1,_col_2,_col_3
-,1,foo,bar
+,1,foo,baz
janriemer
force-pushed
the
diff-boolean-header-option-for-diff-result
branch
from
e275b75 to
fc5189c
Compare
jqnatividad
approved these changes
Nov 1, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a new option for
diff: It is now possible to decide, whether the CSV headers in the compared CSVs should be in the diff output. If neither CSVs have headers and this option is not active (which means the output should have headers), theall_genericstrategy fromrenameis used (_col_1,_col_2, etc.).Closes #1326
Example 1 (no diff, no headers in result):
csv_left.csv
csv_right.csv
Output (nothing will be printed here, because there are no differences and we don't want to print headers in the result):
Example 2 (has diff, no headers in result):
csv_left.csv
csv_right.csv
Output:
Example 3 (has diff, add generic headers):
csv_left.csv
csv_right.csv
Output: