feat: add dataset-level stats #2297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resolves #2288
|
will need to modify a lot of |
jqnatividad
changed the title
warning: usage of `FromIterator::from_iter`
--> src/cmd/stats.rs:789:27
|
789 | work_br = csv::ByteRecord::from_iter(vec![&*header].into_iter().chain(stat));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `.collect()` instead of `::from_iter()`: `vec![&*header].into_iter().chain(stat).collect::<csv::ByteRecord<_>>()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_iter_instead_of_collect
= note: `-W clippy::from-iter-instead-of-collect` implied by `-W clippy::pedantic`
= help: to override `-W clippy::pedantic` add `#[allow(clippy::from_iter_instead_of_collect)]`
warning: implicitly cloning a `ByteRecord` by calling `to_owned` on its dereferenced type
--> src/cmd/stats.rs:803:31
|
803 | stats_br_vec.push(dataset_stats_br.to_owned());
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `dataset_stats_br.clone()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_clone
= note: `-W clippy::implicit-clone` implied by `-W clippy::pedantic`
= help: to override `-W clippy::pedantic` add `#[allow(clippy::implicit_clone)]`
warning: implicitly cloning a `ByteRecord` by calling `to_owned` on its dereferenced type
--> src/cmd/stats.rs:812:31
|
812 | stats_br_vec.push(dataset_stats_br.to_owned());
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `dataset_stats_br.clone()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_clone
warning: implicitly cloning a `ByteRecord` by calling `to_owned` on its dereferenced type
--> src/cmd/stats.rs:825:31
|
825 | stats_br_vec.push(dataset_stats_br.to_owned());
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `dataset_stats_br.clone()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_clone
…re write_dataset_stat
…d use simd_json instead of serde_json
…ng approach also refactor csv_to_jsonl to pass output_jsonl by reference instead of by value
…stead of by value
…vel objects so as not to trigger select where objects starting with _ is a sentinel for last column
…el stats also add assert_succes to select frequency and tojsonl tests to help in debugging
|
merge this now so we can take advantage of the new |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2288