add mime-type checking; better panic handling #2304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
that can be suppressed with QSV_SKIP_FORMAT_CHECK env var
with a better UI/UX
…rs and old default buffer values
warning: immediately dereferencing a reference
--> src/util.rs:1995:54
|
1995 | match simd_json::serde::from_slice(&mut **&mut s_slice) {
| ^^^^^^^^^^^^^ help: try: `s_slice`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof
= note: `#[warn(clippy::deref_addrof)]` on by default
warning: immediately dereferencing a reference
--> src/util.rs:2139:54
|
2139 | match simd_json::serde::from_slice(&mut **&mut s_slice) {
| ^^^^^^^^^^^^^ help: try: `s_slice`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof
warning: deref which would be done by auto-deref
--> src/util.rs:1995:48
|
1995 | match simd_json::serde::from_slice(&mut **&mut s_slice) {
| ^^^^^^^^^^^^^^^^^^^ help: try: `&mut s_slice`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
= note: `#[warn(clippy::explicit_auto_deref)]` on by default
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/util.rs:2126:63
|
2126 | csv_to_jsonl(&tempfile_path, &get_stats_data_types(), &statsdatajson_path)?;
| ^^^^^^^^^^^^^^^^^^^ help: change this to: `statsdatajson_path`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
warning: deref which would be done by auto-deref
--> src/util.rs:2139:48
|
2139 | match simd_json::serde::from_slice(&mut **&mut s_slice) {
| ^^^^^^^^^^^^^^^^^^^ help: try: `&mut s_slice`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
beyond just checking the file extension, actually go the extra mile and do mime-type inferencing.
can be turned off by setting QSV_SKIP_FORMAT_CHECK env var.
Leveraged the
file-formatcrate that is already being used by qsv for thesniffcommand.Also, added better panic UI/UX with
human-paniccrate.resolves #2301