feat: "smart" diff #2518
Merged
feat: "smart" diff #2518
+328
−108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as we use it to create perfect hash functions for the stats cache
to also cache dataset stats
if the stats cache is available for both CSVs, it will use the cache to: - compare fingerprint hashes, and if identical, short-circuit the diff - fetch cardinality from stats cache - fetch rowcount from dataset cache - validate if there is a single --key column, ensuring that cardinality == rowcount (ALL UNIQUE values)
… function, instead of hardcoded const array
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if the stats cache is available for both CSVs, it will use the cache to:
diff: document and include error message for "duplicate primary keys" #2514. However, this validation is only done when there is only a single --key columnpivotpandfrequencynow also use the dataset stats cache to get the row count, instead of calculating the row count.resolves #2493