Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimize rebuilds on git version change #1316

Open
wants to merge 1 commit into
base: next
Choose a base branch
from

Conversation

nick87720z
Copy link
Contributor

@nick87720z nick87720z commented May 22, 2021

For now full rebuild happens when current commit changes, which may happen without actual content change - e.g. something is commited or uncommited via git reset without --hard option. This change makes only necessary files being rebuild - those, using GIT_REVISION.

@DaveDavenport
Copy link
Collaborator

@sardemff7 you added that option, any feedback on this.

I never had issues with this (But rofi compiles so quick, I would not have noticed anyway).

@sardemff7
Copy link
Collaborator

Seems like a good move, but you should put the #include next to the nkutils one, in an #else branch for line 50 #ifdef

It's headache when even doing commit leads to almost full rebuild due to
changed current git version without real content change.
@codecov-commenter
Copy link

codecov-commenter commented May 23, 2021

Codecov Report

Merging #1316 (0614b9f) into next (04c006a) will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #1316      +/-   ##
==========================================
+ Coverage   32.98%   33.04%   +0.06%     
==========================================
  Files          42       42              
  Lines       11934    12024      +90     
==========================================
+ Hits         3936     3973      +37     
- Misses       7998     8051      +53     
Impacted Files Coverage Δ
source/rofi.c 0.00% <ø> (ø)
source/xcb.c 0.00% <0.00%> (ø)
source/view.c 0.00% <0.00%> (ø)
source/dialogs/drun.c 0.00% <0.00%> (ø)
test/theme-parser-test.c 98.31% <0.00%> (+0.03%) ⬆️
source/widgets/widget.c 49.84% <0.00%> (+0.15%) ⬆️
lexer/theme-lexer.l 74.68% <0.00%> (+0.25%) ⬆️
source/theme.c 35.49% <0.00%> (+0.37%) ⬆️
lexer/theme-parser.y 63.97% <0.00%> (+0.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04c006a...0614b9f. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants