Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rofi-sensible-terminal] Use /bin/sh instead of /usr/bin/env bash #1478

Open
wants to merge 1 commit into
base: next
Choose a base branch
from

Conversation

jirutka
Copy link
Contributor

@jirutka jirutka commented Sep 26, 2021

This script is fully POSIX-sh compatible, i.e. it's portable and can be run in any shell, not just bash. It's incorrect to assume that bash is available on every *nix system (it's not), but /bin/sh is.

This script is fully POSIX-sh compatible, i.e. it's portable and can be
run in any shell, not just bash. It's incorrect to assume that bash is
available on every *nix system (it's not), but /bin/sh is.
@metov
Copy link

metov commented Oct 4, 2021

The change to sh seems like a good idea, but isn't it better to make it /usr/bin/env sh?

@jirutka
Copy link
Contributor Author

jirutka commented Oct 4, 2021

isn't it better to make it /usr/bin/env sh?

No, /bin/sh is de-facto standard supported by all *nix systems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants