[WIP] Improve require-input user experience #1765
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whenever the listview has require-input set to true, if the user hasn't entered any text, pressing kb-accept won't have any effect. This prevents auto-selecting the first option blindly, which may lead to unexpected selections (as the user can't see the first item of the list).
elamperti
commented
Dec 20, 2022
Comment on lines
+580
to
+582
| if (lv->require_input && !lv->filtered) { | ||
| return UINT32_MAX; | ||
| } |
There was a problem hiding this comment.
This is enough to avoid auto-selecting the first item when require_input is enabled and there's no input:
elamperti
commented
Dec 20, 2022
Comment on lines
+1731
to
+1733
| if (selected != UINT32_MAX) { | ||
| state->quit = TRUE; | ||
| } |
There was a problem hiding this comment.
And checking the selected value here, before defining it's time to quit, would keep rofi open when require_input is enabled and there's no input. The user can still quit rofi normally by using the expected method, kb-cancel.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever the listview has
require-inputset to true, if the user hasn't entered any text, pressing kb-accept will result in the selection of the first item of the list, even if it's not visible for the user. Also trying to navigate the list (blindly) doesn't change the selected item either.My proposed change prevents auto-selecting the first option blindly, avoiding an unexpected default selection (whatever is the first item in the listview). With this change, rofi remains open until the user either enters the required input and accepts, or presses kb-cancel. This goes in line with the UX of other search/filtering tools, and it should benefit the community users' who use this option.
See more details and ongoing discussion here.