Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added non-sensitivity to keyboard layout #994

Open
wants to merge 8 commits into
base: next
Choose a base branch
from

Conversation

alexkabanov
Copy link

-matching all_kb_layouts

@sardemff7
Copy link
Collaborator

Where is the explanation of this feature? How the user is supposed to know what it’ll do? How are we supposed to know what to review? It needs at least an update to the man page, and I’d appreciate a nice commit message explaining why it is necessary to add and maintain so much code. :-)

@sardemff7
Copy link
Collaborator

You still didn’t describe “non-sensitivity to keyboard layout” at all…
Also, it sounds like something people would want in addition to all the already existing matching methods, which again makes it harder to implement and maintain. You must explain why it is important to have. (And in the commit message, feel free to squash&force-push to your PR, it’ll be nicer when merging.)

@alexkabanov
Copy link
Author

My english is bad. :)
When windows have names in two languages and when rofi launching with input language of last window, then frequently user need switch input language.
It's slowly and uncomfortably.
In this implementation, current device keymap used by to make regular expression. "[qй][wц][eу][rк][tе]". (keyboard layout: en,ru)
Solution, presented in issue "English as default input language", not suit because items may not only be in English. But this feature also solves the problem in issue "English as default input language". It doesn't matter what input language.

@codecov-io
Copy link

codecov-io commented Oct 25, 2020

Codecov Report

Merging #994 into next will increase coverage by 0.32%.
The diff coverage is 58.16%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next     #994      +/-   ##
==========================================
+ Coverage   33.33%   33.65%   +0.32%     
==========================================
  Files          42       43       +1     
  Lines       11802    11954     +152     
==========================================
+ Hits         3934     4023      +89     
- Misses       7868     7931      +63     
Impacted Files Coverage Δ
source/xcb.c 0.00% <0.00%> (ø)
source/xrmoptions.c 15.63% <ø> (ø)
source/keyb-layout.c 15.15% <15.15%> (ø)
source/helper.c 53.25% <84.21%> (+0.91%) ⬆️
test/helper-tokenize.c 97.37% <100.00%> (+0.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8eaeec...74c1a49. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants