feat: notify client by email when invoice is created#289
Open
raymondjoseph02 wants to merge 3 commits intodavedumto:mainfrom
Open
feat: notify client by email when invoice is created#289raymondjoseph02 wants to merge 3 commits intodavedumto:mainfrom
raymondjoseph02 wants to merge 3 commits intodavedumto:mainfrom
Conversation
Add sendInvoiceToClient to lib/email.ts and call it fire-and-forget at the end of POST /api/invoices so the client immediately receives a payment link email without blocking the API response. - Basic email format validation skips send for invalid addresses - Email failures are logged via .catch() and never surface as API errors - Unit tests assert correct params, resilience to send failure, and freelancerName fallback to user.email when name is null EOF
|
@raymondjoseph02 is attempting to deploy a commit to the david's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@raymondjoseph02 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Author
|
Please merge this before another conflict comes up |
Author
|
second time i am fixing conflict on this issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add sendInvoiceToClient to lib/email.ts and call it fire-and-forget at the end of POST /api/invoices so the client immediately receives a payment link email without blocking the API response.
close #283