Add globbing of files for linting

[volovikariel]

This is adds the globbing feature very shortly discussed here: #406 (specifically, here)

It allows for typing something like this vacuum lint --globbed-files="*/**/bu*.openapi.yaml" model/test_files/badref-burgershop.openapi.yaml, which will glob files relative to the current working directory.

It is also possible to combine globbing with the current way of specifying files (just providing filepath(s)), it removes duplicates (meaning, if you provide a filepath twice, or if one of your filepaths provided is also a match result of globbing).

This is my first time actually contributing code to an open source project - so, I'm expecting quite a lot of feedback/criticism. I'm eager to learn!

[daveshanley]

LGTM!

The only other suggestion I have is to add in a TODO that mentions this new functionality needs to be added to other commands as well at some point.

[daveshanley]

Would you be able to rebase?

[volovikariel]

Would you be able to rebase?

Don't totally understand why. Is it to avoid merge commits in the history?

If so - should I squash all of the commits together into a single commit with message "add globbing of files for linting (#406)"?
This would be to avoid commits that have a "broken state" (like my first "checkpoint" commit), for if we ever want to run git bisect to check for some regression.

[daveshanley]

Would you be able to rebase?

Don't totally understand why. Is it to avoid merge commits in the history?

If so - should I squash all of the commits together into a single commit with message "add globbing of files for linting (#406)"? This would be to avoid commits that have a "broken state" (like my first "checkpoint" commit), for if we ever want to run git bisect to check for some regression.

I prefer rebasing to merging for one reason, timeline preservation. because I am the primary contributor to this codebase, I like to see 'blocks' of feature time on my repo timeline.

When we merge, it blends the timeline and I lose track of which author did what bit when. rebasing keeps your contributions cleanly blocked into a segment.

Not every single commit will always build, thats OK, as long as the main branch is always 100% operational.

There is no need to squash, I don't like squashing except for nit commits and cosmetic stuff.

[volovikariel]

I think it should be what you wanted now 🤔

Went through quite a rollercoaster (as you can tell by the many force pushes...) but - the merge commit is gone now 🥳