Added noRequestBody function to check that HTTP GET and DELETE methods do not contain a requestBody#588
Merged
daveshanley merged 7 commits intodaveshanley:mainfrom Jan 2, 2025
Conversation
…s do not contain a request body
…ave a requestBody
…o-request-body-oas-func # Conflicts: # functions/functions_test.go
lobocv
commented
Nov 25, 2024
| Formats: model.OAS3AllFormat, | ||
| Description: "HTTP GET and DELETE should not accept request bodies", | ||
| Given: "$", | ||
| Resolved: false, |
Author
There was a problem hiding this comment.
@daveshanley I don't know what Resolved means. Should it be true or false here?
Owner
There was a problem hiding this comment.
Resolved means that the $ref values have all been stitched together by the resolver in libopenapi
This is used for rules that assume everything is resolved and inlined. It only makes a difference if the logic in your rule / function is recursive - if so, it means that any circular references could create an infinite loop.
Author
|
@daveshanley bump :) |
Owner
Will get to this ASAP, apologies for my slowness. |
daveshanley
reviewed
Jan 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested from here: #582