Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unicodeRange to fontFace #513

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

pedrobslisboa
Copy link
Contributor

Description

It was missing the unicode-range property on fontFace. This PR adds it.
It also ran the make format

The unicode-range works under this type:

  type t =
    [ `single of string
    (* E.g. `single "1234" U+1234 *)
    | `range of string * string
    (* E.g. `range ("1234", "5678") U+1234-U+5678 *)
    | `wildcard of string * string
    (* E.g. `wildcard ("12", "??") U+12?? *)
    ]
    array

@davesnx I'm not so happy with ``wildcard ("12", "??")`. Do you have a better idea?

Copy link

vercel bot commented Sep 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
styled-ppx ⬜️ Ignored (Inspect) Visit Preview Sep 30, 2024 8:14pm

@davesnx
Copy link
Owner

davesnx commented Sep 30, 2024

@davesnx I'm not so happy with ``wildcard ("12", "??")`. Do you have a better idea?

what about ``wildcard ("12")` and render ?? directly?

@@ -1046,6 +1061,7 @@ let tests =
avoid_hash_collision;
keyframe;
global;
fontFace;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice test

@pedrobslisboa
Copy link
Contributor Author

@davesnx I'm not so happy with ``wildcard ("12", "??")`. Do you have a better idea?

what about ``wildcard ("12")` and render ?? directly?

I wonder if U+4? matches: U+40, U+400, U+4000, U+4000... . If don't, adding ?? dynamically may not be possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants