Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed http output code 404 although the node is reserved #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed http output code 404 although the node is reserved #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/controllers/api/v2/reserves_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ def reserve
respond_to do |format|
format.json { render :json => @hosts }
format.yaml { render :text => @hosts.to_yaml }
format.html { not_found }
format.html { render :json => hosts }
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be @hosts?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi David,

unfortunately I don't have any clue about Ruby prog. language. I don't know what semantics change means @hosts instead of hosts. My guess comes from other outcomes (other methods implemented there) from reserves_controller.rb.

I can see there that there is a mixture of either hosts or @hosts, from quick search I understand that @hosts is an instance variable under self, but in that case I don't understand if method reserve is correctly implemented too.

Do you know what is correct in this case?

Thank you, Pavel

end
end

Expand Down