examples: port from structopt to clap/derive#20
Open
decathorpe wants to merge 1 commit intodavidbarsky:mainfrom
Open
examples: port from structopt to clap/derive#20decathorpe wants to merge 1 commit intodavidbarsky:mainfrom
decathorpe wants to merge 1 commit intodavidbarsky:mainfrom
Conversation
Owner
|
Thanks! seems reasonable to me. I don't know how much this intersects with packaging, but you need me to do a release? |
Owner
|
I'll fix the clippy issues later today. |
Author
|
Thanks! I don't need a new release immediately, I can apply an equivalent patch in the Fedora package independently. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
structoptcrate is obsolete, it continues to depend on clap v2, and its functionality was merged into clap itself as of v3. So porting fromstructopt::StructOpttoclap::Parseris straightforward (just replacing some names).