Skip to content

Commit

Permalink
fix: minor fixes and change
Browse files Browse the repository at this point in the history
- use after_stat instead of stat in examples
- remove R_REMOTES_NO_ERRORS_FROM_WARNINGS from CI
  • Loading branch information
davidgohel committed Dec 9, 2023
1 parent b1e2c37 commit 4a9ecf5
Show file tree
Hide file tree
Showing 10 changed files with 16 additions and 17 deletions.
7 changes: 3 additions & 4 deletions .github/workflows/R-CMD-check.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ jobs:
- {os: ubuntu-latest, r: 'release'}
env:
GITHUB_PAT: ${{ secrets.GITHUB_TOKEN }}
R_REMOTES_NO_ERRORS_FROM_WARNINGS: true

steps:
- uses: actions/checkout@v2
Expand All @@ -40,9 +39,9 @@ jobs:

- uses: r-lib/actions/setup-r-dependencies@v2
with:
cache-version: 2
extra-packages: >
any::rcmdcheck
extra-packages: any::rcmdcheck
needs: check

- uses: r-lib/actions/check-r-package@v2
with:
upload-snapshots: true
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ Package: ggiraph
Type: Package
Title: Make 'ggplot2' Graphics Interactive
Description: Create interactive 'ggplot2' graphics using 'htmlwidgets'.
Version: 0.8.8.002
Version: 0.8.8.003
Authors@R: c(
person("David", "Gohel", role = c("aut", "cre"),
email = "[email protected]"),
Expand Down
4 changes: 2 additions & 2 deletions examples/geom_density_2d_interactive.R
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@ x <- girafe_options(x = x,
if (interactive()) print(x)


p <- d + stat_density_2d(aes(fill = stat(nlevel),
tooltip = paste("nlevel:", stat(nlevel))),
p <- d + stat_density_2d(aes(fill = after_stat(nlevel),
tooltip = paste("nlevel:", after_stat(nlevel))),
geom = "interactive_polygon") +
facet_grid(. ~ cut) + scale_fill_viridis_c_interactive(tooltip = "nlevel")
x <- girafe(ggobj = p)
Expand Down
2 changes: 1 addition & 1 deletion examples/geom_density_interactive.R
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ p <- ggplot(diamonds, aes(carat, fill = cut)) +
x <- girafe(ggobj = p)
if( interactive() ) print(x)

p <- ggplot(diamonds, aes(carat, stat(count), fill = cut)) +
p <- ggplot(diamonds, aes(carat, after_stat(count), fill = cut)) +
geom_density_interactive(aes(tooltip=cut, data_id=cut), position = "fill")
x <- girafe(ggobj = p)
if( interactive() ) print(x)
2 changes: 1 addition & 1 deletion examples/scale_viridis_guide_bins_interactive.R
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ set.seed(4393)
dsmall <- diamonds[sample(nrow(diamonds), 1000),]
p <- ggplot(dsmall, aes(x, y)) +
stat_density_2d(aes(
fill = stat(nlevel),
fill = after_stat(nlevel),
tooltip = paste("nlevel:", after_stat(nlevel))
),
geom = "interactive_polygon") +
Expand Down
4 changes: 2 additions & 2 deletions examples/scale_viridis_guide_coloursteps_interactive.R
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ set.seed(4393)
dsmall <- diamonds[sample(nrow(diamonds), 1000),]
p <- ggplot(dsmall, aes(x, y)) +
stat_density_2d(aes(
fill = stat(nlevel),
tooltip = paste("nlevel:", stat(nlevel))
fill = after_stat(nlevel),
tooltip = paste("nlevel:", after_stat(nlevel))
),
geom = "interactive_polygon") +
facet_grid(. ~ cut)
Expand Down
4 changes: 2 additions & 2 deletions man/geom_density_2d_interactive.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion man/geom_density_interactive.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion man/guide_bins_interactive.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions man/guide_coloursteps_interactive.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 4a9ecf5

Please sign in to comment.