Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update #269 #284

Merged
merged 9 commits into from
Feb 23, 2024
Merged

update #269 #284

merged 9 commits into from
Feb 23, 2024

Conversation

davidgohel
Copy link
Owner

Updates for ggplot2-3.5 new system for guides

@codecov-commenter
Copy link

codecov-commenter commented Feb 11, 2024

Codecov Report

Attention: 45 lines in your changes are missing coverage. Please review.

Comparison is base (82819d7) 96.27% compared to head (df2d6f6) 94.36%.

Files Patch % Lines
R/guide_interactive.R 69.64% 34 Missing ⚠️
R/geom_violin_interactive.R 0.00% 9 Missing ⚠️
R/guide_colourbar_interactive.R 0.00% 1 Missing ⚠️
R/guide_coloursteps_interactive.R 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #284      +/-   ##
==========================================
- Coverage   96.27%   94.36%   -1.91%     
==========================================
  Files         106      106              
  Lines        2685     2682       -3     
==========================================
- Hits         2585     2531      -54     
- Misses        100      151      +51     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidgohel
Copy link
Owner Author

Hello @teunbrand, this new PR will be send to CRAN after the new version of ggplot2 has been put on CRAN.

@davidgohel davidgohel merged commit 3672a99 into master Feb 23, 2024
7 of 9 checks passed
@davidgohel davidgohel deleted the pr-269 branch May 7, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants