Add toggleable macro elements summary in category footer to see macro…

[mgrzaslewicz]

… elements per meal easily

Before

I found it hard to see how much protein and other macros I should add to particular meal (category). I could achieve that by clicking on calories button and see category nutriments. Then after closing the dialog I could already forget macros values. And it required way too many clicks.

After

There is:

• new Diary setting called 'Show macros summary per category'. Turned off by default
• macro nutriments summary next to calories, e.g. 'P15 / F20/ C52 400 kcal'. Prefixes stand for protein, fat, carbohydrate.
• displaying macro nutriments summary is aligned with goal displaying in diary footer. e.g. if fat is not displayed in the diary footer, it won't be displayed in category summary

I know there are missing translations, but I don't want to invest too much upfront in this pull request without knowing the likelihood of merging it.

[davidhealey]

Do you think there is enough room to put the full name, "Protein", "Carbs", "Fat" rather than individual letters?

[mgrzaslewicz]

Do you think there is enough room to put the full name, "Protein", "Carbs", "Fat" rather than individual letters?

I don't think so

edit: with just 'Carbs' it might fit, but I'm not sure if it looks good

edit2: on smaller devices it doesn't fit

[davidhealey]

Yeah with Carbs it looks ok, could we put the unit after it too?

[mgrzaslewicz]

Yeah with Carbs it looks ok, could we put the unit after it too?

see my edited comment about smaller devices.
I think to 'fit them all' it could be like 'P 17g / F 3g / C 2g'

[davidhealey]

Yeah you're right, any idea if other apps have this feature and how they solve the layout?

[mgrzaslewicz]

Yeah you're right, any idea if other apps have this feature and how they solve the layout?

RP diet has a meal (category) focus and you can adjust everything easily. That's what I miss in this project.
Plus there is target for each meal which in an easy case would be macro target per day / number of meals, but just seeing macros summary below it might be already good enough

[davidhealey]

Ok let's work with your original idea, just the letters and no units.

[mgrzaslewicz]

Ok let's work with your original idea, just the letters and no units.

Ok. Anything else needed apart from translations and package.json to be moved out of PR scope?

[davidhealey]

At first glance it all looks good to me.

[mgrzaslewicz]

I've improved the feature to align displaying category summary nutriments with goal settings as after using app for some time it just makes sense.

@EmilJunker @davidhealey Can I somehow help you to move forward with this pull request and release?

[davidhealey]

Did you resolve all of @EmilJunker's comments? (looks like you did)

[mgrzaslewicz]

Did you resolve all of @EmilJunker's comments? (looks like you did)

Yes