build: Use gnome.post_install() #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bobby285271
commented
Apr 21, 2023
bobby285271
commented
- See post_install.py fails if GTK 3 is not installed (granite-7) elementary/granite#584
- Also bumps version in meson.build
When GTK3 is not installed, gtk-update-icon-cache is not available. By using gnome.post_install() we can use gtk4-update-icon-cache provided by GTK4.
|
Oh opened too fast. I guess #197 contains this already. In Nixpkgs packaging replacing |
12 tasks
|
I'm happy to merge this as there will probably be at least one more minor release before the rewrite lands. Thank you! |
davidmhewitt
approved these changes
Apr 21, 2023
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.