Add automap support for concrete classes #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #53 +/- ##
============================================
- Coverage 77.64% 76.86% -0.79%
- Complexity 669 675 +6
============================================
Files 73 73
Lines 2747 2792 +45
Branches 240 249 +9
============================================
+ Hits 2133 2146 +13
- Misses 508 540 +32
Partials 106 106
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, @davidmoten!
Thank you for your work on this project, it's very useful and it definitely helps a lot of developers.
I noticed that auto-map support for concrete classes was dropped on this project (comparing to
rxjava-jdbcproject), for the reasons you mentioned on issue #15, which I completely understand.However, it is an important feature that is really needed, mostly for the ones who migrate from
rxjava-jdbc, which need to update their models to be compatible with this new project.In alignment to your expressed intention (in the above mentioned issue) to add back that functionality, I decided to take some time to explore the code and see if I can add it back on (and this PR is the result of that effort).
I mainly took the code from the
rxjava-jdbcand I integrated it here, as best as I could, and I also added a small unit test to see if it works as expected.Thank you and let me know what you think about it!