Update all dependencies #36
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lockfiles shouldn’t exist at all, but most of the harm they do can be mitigated by keeping them as ephemeral as possible. In particular, they should not be committed to version control ever. Delete the erroneously committed lockfile and discourage it from being re-added by adding it to .gitignore. /En passant/ add leading slashes to several other entries in .gitignore that should only exist at top level. This, all by itself, resolves 12 of the 17 buggy dependencies reported by ‘npm audit‘, neatly demonstrating why lockfiles are bad.
This is minor except for cheerio, which goes from 0.22.0 to 1.0.0~rc.12, and mocha, which goes from 6.x to 10.x. No code changes are required, all tests pass. Bump version to 1.0.3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update all dependencies to their latest .0 releases (except for cheerio, which is still working on its 1.0.0 -- I wouldn't normally write a >= dependency on a release candidate but the goal here is to get rid of the transitive dependency on an old version of css-select, and cheerio only got around to fixing that in the middle of their release candidate series).
Subsumes dependabot PRs #27, #28, #30, #34, and #35.