Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update postgres exporter, add podmonitor support #63

Merged
merged 12 commits into from
Oct 2, 2024

Conversation

bobertrublik
Copy link

@bobertrublik bobertrublik commented Sep 27, 2024

Issue:

Still work in progress.

@bobertrublik bobertrublik force-pushed the upgrade-postgres-exporter branch 2 times, most recently from 46f03c1 to cc97aac Compare September 27, 2024 15:03
@bobertrublik bobertrublik force-pushed the upgrade-postgres-exporter branch 6 times, most recently from ccfdb20 to 0b88cbb Compare October 1, 2024 08:54
@bobertrublik bobertrublik force-pushed the upgrade-postgres-exporter branch from 0b88cbb to 05ae4ef Compare October 1, 2024 09:25
@bobertrublik bobertrublik force-pushed the upgrade-postgres-exporter branch from 05ae4ef to 3cbd811 Compare October 1, 2024 11:01
@bobertrublik bobertrublik marked this pull request as ready for review October 1, 2024 11:18
@bobertrublik
Copy link
Author

bobertrublik commented Oct 1, 2024

I renamed the test script file to a more generic name and the pipeline seems to have issues with it.
Here it tries to deploy the previous version 2.3.4 but for some reason it prints the new file name?

Error: UPGRADE FAILED: template: db-instances/templates/tests/test_monitoring.yaml:1:14: executing "db-instances/templates/tests/test_monitoring.yaml" at <.Values.tests.monitoring.enabled>: nil pointer evaluating interface {}.enabled

If I understand this correctly it tries to use the old values file for the updated chart? helm/chart-testing#525

@allanger
Copy link
Member

allanger commented Oct 1, 2024

If I understand this correctly it tries to use the old values file for the updated chart? helm/chart-testing#525

The upgrade test is sometimes weird, and I'm not sure which values it's using while upgrading, so it might be the case

@bobertrublik
Copy link
Author

If I understand this correctly it tries to use the old values file for the updated chart? helm/chart-testing#525

The upgrade test is sometimes weird, and I'm not sure which values it's using while upgrading, so it might be the case

I think it simply uses the old values file for the new chart to test if people upgrading the chart without reading the changelog run into any issues.

@allanger allanger merged commit 36f241a into db-operator:main Oct 2, 2024
10 checks passed
@allanger
Copy link
Member

allanger commented Oct 2, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants