Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to load compiled library from lib and ext to handle rubygems … #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thekendalmiller
Copy link

…moving the library

This seems to be how other gems with native extensions handle it

lib/levenshtein.rb Outdated Show resolved Hide resolved
@Laykou
Copy link

Laykou commented Jan 15, 2023

I see this is fixes issue when upgrading to Ruby 3.2.

Could this be merged?

@alishersadikov
Copy link

We are upgrading our Ruby version and ran into the underlying issue too. Hoping it can be merged soon.

@caiobsilva
Copy link

Thank you for this! Are the maintainers aware/planning to merge this issue?
@dbalatero? 👀

@Laykou
Copy link

Laykou commented Jul 14, 2023

Could this be merged please?

@harto
Copy link

harto commented Sep 13, 2023

+1, would be great to have this fix incorporated

ascheink added a commit to remix/levenshtein-ffi that referenced this pull request Sep 14, 2023
@Laykou
Copy link

Laykou commented May 13, 2024

Could this be merged and released as a new version please?

@BigAirJosh
Copy link

another bump for a merge 🙏

@Estiennejeremy
Copy link

Another up too for the merge please 🙏

@dbalatero
Copy link
Owner

dbalatero commented May 28, 2024

Sorry, I haven't been working in Ruby for quite a few years now and need to page all this back into memory.

I can merge but I don't want to break old Ruby versions. This repo lacks CI, so I think I'd like to add that first, then see if this PR passes CI (maybe on a matrix of versions). Let me do that first, then look at this PR.

For now, you can point your Gemfiles at the fork/branch that implements this, if you need the fix today.

@dbalatero
Copy link
Owner

Blegh, I tried to open a PR against my own repo but it's going to the repo I forked from years ago. I think I either have to push my broken CI PR to master to add CI support, or detach from the fork to get my CI PR in.

I can detach this repo from the original repo, but it will drop all pull requests and issues and recreate the repo, so we'll lose all the bug context here which also sucks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants