Parser permit inline comments (untested)#120
Closed
Woccz wants to merge 1 commit intodbaumgarten:developfrom
Closed
Parser permit inline comments (untested)#120Woccz wants to merge 1 commit intodbaumgarten:developfrom
Woccz wants to merge 1 commit intodbaumgarten:developfrom
Conversation
Contributor
Author
|
Incorrect Parser |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it**:
Allows for inlining of comments in nolol.
This seems like the simple fix, however if this same parser is used between yolol and nolol, it would allow for inline commenting in yolol, which is illegal.
I am not sure if this is the case?
I am also not certain that the compiler will correctly comment out after the token?
Which issue(s) this PR fixes**:
Fixes #53
Checklist: