Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump arbor version to 0.10 #3

Merged
merged 6 commits into from
Aug 14, 2024
Merged

fix: bump arbor version to 0.10 #3

merged 6 commits into from
Aug 14, 2024

Conversation

drodarie
Copy link
Contributor

@drodarie drodarie commented Aug 13, 2024

What has been done

  • Bump arbor version to 0.10
  • Add units to quantities passed to arbor functions.
  • Bump bsb versions.
  • Add test and dev installation
  • Fix main.yml as tests were not performed

Related issues

close dbbs-lab/bsb-core#878

Add units to quantities passed to arbor functions.
Bump bsb functions.
@drodarie drodarie requested a review from Helveg August 13, 2024 11:57
@drodarie drodarie self-assigned this Aug 13, 2024
Copy link
Contributor

@Helveg Helveg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just questions about the dependencies. It generally is bad for compatibility to hike up the dependencies for no reason.

pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
tests/test_arbor.py Show resolved Hide resolved
@drodarie drodarie requested a review from Helveg August 14, 2024 13:57
@drodarie drodarie merged commit 7a4fd1c into main Aug 14, 2024
7 checks passed
@drodarie drodarie deleted the fix/arbor0.10 branch August 14, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TestSimulate fails
2 participants