Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Robin's errr package to prepare for better exception handling #82

Merged
merged 2 commits into from
Sep 10, 2020

Conversation

Helveg
Copy link
Contributor

@Helveg Helveg commented Sep 10, 2020

Describe the work done

My package makes it easy to pass along detailed information with exceptions, something we can use in the NEURON adapter (https://github.com/dbbs-lab/bsb/issues/50). Currently I've only used it to collapse the exception tree by a 3-fold but on the simulation-recorders branch I will need it for other things.

@codecov
Copy link

codecov bot commented Sep 10, 2020

Codecov Report

Merging #82 into master will decrease coverage by 0.38%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      dbbs-lab/bsb-core#82      +/-   ##
==========================================
- Coverage   63.44%   63.06%   -0.39%     
==========================================
  Files          64       64              
  Lines        7348     7272      -76     
==========================================
- Hits         4662     4586      -76     
  Misses       2686     2686              
Impacted Files Coverage Δ
bsb/exceptions.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 768e347...38683e6. Read the comment docs.

@Helveg Helveg merged commit bb23709 into master Sep 10, 2020
@Helveg Helveg deleted the errr-exceptions branch September 10, 2020 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant